Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean-up for some packages in haskell-modules/configuration-common.nix. #89513

Merged
merged 14 commits into from Jun 5, 2020
Merged

Clean-up for some packages in haskell-modules/configuration-common.nix. #89513

merged 14 commits into from Jun 5, 2020

Conversation

Anton-Latukha
Copy link
Contributor

Motivation for this change

Clean-ups and more informative docs to: {haddock-library, haddock-library_1_9_0, pandoc (1.2.7), hnix, generic-lens, dhall, dhall-json, dhall-nix}

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Anton-Latukha Anton-Latukha mentioned this pull request Jun 4, 2020
Closed
cdepillabout
cdepillabout requested changes Jun 5, 2020
View reviewed changes
Copy link
Member

@cdepillabout cdepillabout left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the request for hnix below, this looks good. I'll merge this in when the hnix things have been addressed.

Thanks for taking them time to fix this sort of stuff up!

pkgs/development/haskell-modules/configuration-common.nix Outdated Show resolved Hide resolved
@Anton-Latukha
hnix: rm no longer relevant comments
6c71418 
Cleaning up old comments that do not hold.

M  pkgs/development/haskell-modules/configuration-common.nix
@Anton-Latukha
hnix: add documentation why dontCheck
446df27 
M  pkgs/development/haskell-modules/configuration-common.nix
@Anton-Latukha
hnix: rm these override, package requires these >= 1.0.2
717ce0e 
M  pkgs/development/haskell-modules/configuration-common.nix
@Anton-Latukha
rm these_0_7_6, no longer used package version
74ae081 
Was require by old hnix version.

M  pkgs/development/haskell-modules/configuration-hackage2nix.yaml
@Anton-Latukha
hnix: rm doJailbreak
ddff404 
M  pkgs/development/haskell-modules/configuration-common.nix
@Anton-Latukha
hnix: rm from broken-packages
099c56a 
M  pkgs/development/haskell-modules/configuration-hackage2nix.yaml
@Anton-Latukha
dhall: document proposed idea upstream to solve dontCheck
6d0f6e7 
M  pkgs/development/haskell-modules/configuration-common.nix
@Anton-Latukha
dhall-json: enable check
b8bfa76 
M  pkgs/development/haskell-modules/configuration-common.nix
@Anton-Latukha
dhall-json: rm upstream issue link, no loner relevant
6fa6a0c 
M  pkgs/development/haskell-modules/configuration-common.nix
@Anton-Latukha
haddock-library: enable deps and checks, they are fine
6f6e316 
M  pkgs/development/haskell-modules/configuration-common.nix
@Anton-Latukha
haddock-library_1_9_0: enable deps and checks, they are fine
44093a7 
M  pkgs/development/haskell-modules/configuration-common.nix
@Anton-Latukha
haddock-library{,_1_9_0}: rm no longer relevant note
43896ac 
M  pkgs/development/haskell-modules/configuration-common.nix
@Anton-Latukha
generic-lens: change upstream report link to relevant
d2cd573 
M  pkgs/development/haskell-modules/configuration-common.nix
@Anton-Latukha
pandoc: update the note why dontCheck
e12399c 
M  pkgs/development/haskell-modules/configuration-common.nix
@peti peti merged this pull request into NixOS:haskell-updates Jun 5, 2020
@Anton-Latukha Anton-Latukha mentioned this pull request Jun 5, 2020
Closed
@Anton-Latukha
Copy link
Contributor Author

Anton-Latukha commented Jun 5, 2020 •
edited

Other than the request for hnix below, this looks good. I'll merge this in when the hnix things have been addressed.

Thanks for taking them time to fix this sort of stuff up!

Very good honest and effective responce to contributers, thank you @cdepillabout 8)

@Anton-Latukha Anton-Latukha deleted the upd-haskell-pkg-01 branch June 6, 2020 17:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell 8.has: clean-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Anton-Latukha @cdepillabout @peti