Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

owslib: add pyyaml as a runtime dep #89451

Merged
merged 1 commit into from Jun 4, 2020
Merged

owslib: add pyyaml as a runtime dep #89451

merged 1 commit into from Jun 4, 2020

Conversation

tviti
Copy link
Contributor

@tviti tviti commented Jun 4, 2020

Motivation for this change

This commit in the owslib repo added pyyaml as a dependency, so trying to build the derivation results in the following error message:

ERROR: Could not find a version that satisfies the requirement pyyaml (from OWSLib==0.19.2) (from versions: none)
ERROR: No matching distribution found for pyyaml (from OWSLib==0.19.2)

This commit adds pyyaml to the derivation as a runtime dep, so that it can build successfully.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tviti
Copy link
Contributor Author

tviti commented Jun 4, 2020

EDIT: Crap, sorry, was trying to cance comment, not close this.

@tviti tviti closed this Jun 4, 2020
@tviti tviti reopened this Jun 4, 2020
@bhipple
Copy link
Contributor

bhipple commented Jun 4, 2020

Result of nixpkgs-review pr 89451 1

6 packages built:
- python37Packages.cartopy
- python37Packages.owslib
- python38Packages.cartopy
- python38Packages.owslib
- qgis
- qgis-unwrapped

@bhipple bhipple merged commit 9a64d6b into NixOS:master Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants