Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

homepage: Fix horizontal scroll on narrower widths #438

Closed
wants to merge 2 commits into from

Conversation

samueldr
Copy link
Member

@samueldr samueldr commented Jun 4, 2020

This is not trivially screenshotable, you have to compare by resizing the window.

I had to break out of bootstrap for the side-by-side "hero" unit, I can't see a non-hacky way full of custom rules compared to letting the flexbox layout deal with it.

Note that this also adds overflow-x to all the examples at the bottom, which otherwise would be wrapped weirdly. I find that neither options (wrapping weirdly or scrollbars) are satisfactory on wider widths, but on phone widths I know for sure scrolling horizontally those examples is better.

The asciinema box will be weird. I don't know if we can somehow make its text automagically rather than force an horizontal scroll (or worse, cutting off according to its defaults!).

This actually acts more fluidly than the bootstrap "row-fluid", in that
we can properly force a width on one element, and let the other expand
as needed.
@samueldr samueldr requested a review from garbas June 4, 2020 00:50
@garbas
Copy link
Member

garbas commented Jun 4, 2020

@samueldr 👍 , i will close this PR and push your branch to this repo and then open a PR from there. this will then create a preview.

@garbas garbas closed this Jun 4, 2020
@samueldr samueldr deleted the fix/index-horizontal-scroll branch June 4, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants