Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

netbeans: 11.3 -> 12.0 #89492

Merged
merged 2 commits into from Jun 18, 2020
Merged

netbeans: 11.3 -> 12.0 #89492

merged 2 commits into from Jun 18, 2020

Conversation

asbachb
Copy link
Contributor

@asbachb asbachb commented Jun 4, 2020 •
edited

Motivation for this change

Update to latest release version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
 asbachb@nixos  ~/dev/src/nix/nixpkgs   update-netbeans  nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
these paths will be fetched (0.03 MiB download, 0.13 MiB unpacked):
  /nix/store/c728dk909vmi1pf5h9qdchinrqcpzcmk-nixpkgs-review-2.3.1
copying path '/nix/store/c728dk909vmi1pf5h9qdchinrqcpzcmk-nixpkgs-review-2.3.1' from 'https://cache.nixos.org'...
$ git -c fetch.prune=false fetch --force https://github.com/NixOS/nixpkgs master:refs/nixpkgs-review/0
From https://github.com/NixOS/nixpkgs
   3bc5b8593be..cda41cf743f  master     -> refs/nixpkgs-review/0
$ git worktree add /home/asbachb/.cache/nixpkgs-review/rev-f934854b9e7cb1d86d57b0d74e3c39664e9d6eed-dirty/nixpkgs cda41cf743f0942aa3f1833d5e0385ad585fa411
Preparing worktree (detached HEAD cda41cf743f)
Updating files: 100% (21821/21821), done.
HEAD is now at cda41cf743f josm: 16239 -> 16538
$ nix-env -f /home/asbachb/.cache/nixpkgs-review/rev-f934854b9e7cb1d86d57b0d74e3c39664e9d6eed-dirty/nixpkgs -qaP --xml --out-path --show-trace
No diff detected, stopping review...
$ git worktree prune
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from svanderburg and rszibele June 4, 2020 17:32
@asbachb asbachb changed the title Update netbeans netbeans: 11.3 -> 12.0 Jun 5, 2020
@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/189

@asbachb
Copy link
Contributor Author

asbachb commented Jun 16, 2020 

 asbachb@nixos  ~/dev/src/nix/nixpkgs   update-netbeans  nix-shell -p netbeans -I nixpkgs=/home/asbachb/dev/src/nix/nixpkgs
[nix-shell:~/dev/src/nix/nixpkgs]$ netbeans

20200616_20h08m54s_grim

@asbachb
Copy link
Contributor Author

asbachb commented Jun 16, 2020

/cc @khumba @NeQuissimus @joelmo

@danieldk
Copy link
Contributor

nix-review is happy, NetBeans also seems to run fine (though I don't have a Java project to test).

Any particular reason to update the JDK dependency to 11?

@asbachb
Copy link
Contributor Author

asbachb commented Jun 17, 2020

Basically I switched to JDK 11 since it's the latest LTS release.
That might break existing installations when using java 8 projects. I guess adding that information in the release notes could make sense?

@danieldk
Copy link
Contributor

Basically I switched to JDK 11 since it's the latest LTS release.

Fair enough!

That might break existing installations when using java 8 projects. I guess adding that information in the release notes could make sense?

It seems that this hasn't been done with prior Eclipse or IntelliJ updates, but since it changes the default JDK, seems like adding a short blurb ensures nobody is caught off-guard.

@asbachb asbachb requested a review from danieldk June 17, 2020 21:05
khumba
khumba approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@khumba khumba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me 👍.

danieldk
danieldk approved these changes Jun 18, 2020
View reviewed changes
Copy link
Contributor

@danieldk danieldk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks for making the changes!

nix-review is happy:

1 package blacklisted:
tests.nixos-functions.nixos-test

1 package built:
netbeans

Tested running and seems to work great.

@danieldk danieldk merged commit f3867b2 into NixOS:master Jun 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danieldk danieldk danieldk approved these changes

@khumba khumba khumba approved these changes

@svanderburg svanderburg Awaiting requested review from svanderburg

@rszibele rszibele Awaiting requested review from rszibele

Assignees
No one assigned
Labels
6.topic: nixos 8.has: changelog 8.has: documentation 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@asbachb @nixos-discourse @danieldk @khumba