Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

rename the url attribute to instance #3662

Closed
wants to merge 2 commits into from
Closed

rename the url attribute to instance #3662

wants to merge 2 commits into from

Conversation

Kloenk
Copy link
Member

@Kloenk Kloenk commented Jun 4, 2020

This renames the url attribute created in #3660 and adds a url info to the output of nix flake info

./result/bin/nix flake info gitlab:kloenk/dwarffs\?instance=git.thevillage.chat
Resolved URL:  gitlab:kloenk/dwarffs?instance=git.thevillage.chat
Locked URL:    gitlab:kloenk/dwarffs/799b8e0abc624e440bc35c38f4b5a08ce981df4a?instance=git.thevillage.chat
Description:   A filesystem that fetches DWARF debug info from the Internet on demand
Path:          /nix/store/v6xvpisgmnp2qwjbcl5xl735g7md2c6l-source
Revision:      799b8e0abc624e440bc35c38f4b5a08ce981df4a
Last modified: 2020-05-11 19:41:56

@Kloenk
Copy link
Member Author

Kloenk commented Jun 4, 2020

Rebase it to the value_or() version

@Kloenk Kloenk force-pushed the selfhost-info branch 3 times, most recently from 0e2a778 to 6fff6f9 Compare June 5, 2020 08:39
edolstra
edolstra requested changes Jun 5, 2020
View reviewed changes
src/libexpr/flake/flakeref.cc Outdated Show resolved Hide resolved
@Kloenk Kloenk requested a review from edolstra June 8, 2020 19:33
edolstra
edolstra reviewed Jun 9, 2020
View reviewed changes
src/libfetchers/github.cc Outdated Show resolved Hide resolved
@Kloenk Kloenk mentioned this pull request Jun 13, 2020
Closed
@Kloenk
Copy link
Member Author

Kloenk commented Jun 13, 2020

I also added a gitea libfetcher for selfhostet gitea, and fixed the github fetcher.

The github fetcher was missing an acces_token for the rev api.

@stale
Copy link

stale bot commented Feb 12, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the stale label Feb 12, 2021
@stale
Copy link

stale bot commented Apr 16, 2022

I closed this issue due to inactivity. → More info

@stale stale bot closed this Apr 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edolstra edolstra edolstra requested changes

Assignees
No one assigned
Labels
stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Kloenk @edolstra