Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mailman updates #89459

Merged
merged 8 commits into from Jun 6, 2020
Merged

Mailman updates #89459

merged 8 commits into from Jun 6, 2020

Conversation

alyssais
Copy link
Member

@alyssais alyssais commented Jun 4, 2020

Targeting staging because some dependencies needed updating and cause a mass rebuild.

importlib-resources no longer build on Python 2.

Upgraded mailman running fine for me.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@globin
Copy link
Member

globin commented Jun 4, 2020

cc @lheckemann

@FRidh
Copy link
Member

FRidh commented Jun 4, 2020

importlib-resources no longer build on Python 2.

We should keep an older compatible version around for Python 2, this is a core package.

@alyssais
Copy link
Member Author

alyssais commented Jun 4, 2020 via email

@alyssais
Copy link
Member Author

alyssais commented Jun 4, 2020 via email

@FRidh

This comment has been minimized.

1 similar comment
@FRidh

This comment has been minimized.

@alyssais alyssais merged commit 9e59980 into NixOS:staging Jun 6, 2020
@alyssais alyssais deleted the mailman branch June 6, 2020 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants