New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrate new search #454
Integrate new search #454
Conversation
@samueldr i think search.nixos.org is now ready to take place of packages-explorer. Am I missing something? |
See the issues referencing this PR |
(Unrelated to the search itself, but a task to validate for the transition.) We have to ensure that the redirects will transmit the query string and the anchor. I believe the anchor is fine, as this is done by the browser on redirect, the server has no way to influence it. This is to ensure that an old link to The options page is the one that requires a bit more finesse. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See the [review]
issues at the search project. Except for trivial cosmetic issues, the others I believe should be handled before moving. Especially those that either change the existing behaviour, or break URLs.
@samueldr thank you thank you thank you :) I will go over the issues and try to address them. |
And thank you again for your hard work. I personally know it's not easy re-implementing such a fundamental part of the website. |
8e22b4b
to
6803acf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't believe we should change until all the blockers are fixed, or at the very least fully investigated and found to not be possible at all.
Blockers were now fixed |
Note for people stumbling over this PR from other issues: |
fixes NixOS/nixos-search#50
This change is