Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate new search #454

Merged
merged 9 commits into from Aug 20, 2020
Merged

Integrate new search #454

merged 9 commits into from Aug 20, 2020

Conversation

garbas
Copy link
Member

@garbas garbas commented Jun 4, 2020

fixes NixOS/nixos-search#50


This change is Reviewable

@github-actions
Copy link
Contributor

github-actions bot commented Jun 5, 2020

@garbas garbas requested a review from samueldr June 5, 2020 00:00
@garbas garbas self-assigned this Jun 5, 2020
@garbas garbas added the enhancement New feature or request label Jun 5, 2020
@garbas
Copy link
Member Author

garbas commented Jun 5, 2020

@samueldr i think search.nixos.org is now ready to take place of packages-explorer. Am I missing something?

@samueldr
Copy link
Member

samueldr commented Jun 5, 2020

See the issues referencing this PR

@samueldr
Copy link
Member

samueldr commented Jun 5, 2020

(Unrelated to the search itself, but a task to validate for the transition.)

We have to ensure that the redirects will transmit the query string and the anchor. I believe the anchor is fine, as this is done by the browser on redirect, the server has no way to influence it.

This is to ensure that an old link to /nixos/packages.html?*whatever* gets redirected to search.nixos.org/packages?*whatever*.

The options page is the one that requires a bit more finesse. /nixos/options.html#something needs to be redirected to search.nixos.org/options?query=something. This can either be done by having a dummy html page that handles rewriting to a query string at the location of the old options.html page, or by having the Elm app know about that specific. There are many links online linking to that anchor-based permalink scheme.

Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See the [review] issues at the search project. Except for trivial cosmetic issues, the others I believe should be handled before moving. Especially those that either change the existing behaviour, or break URLs.

@garbas
Copy link
Member Author

garbas commented Jun 6, 2020

@samueldr thank you thank you thank you :) I will go over the issues and try to address them.

@samueldr
Copy link
Member

samueldr commented Jun 6, 2020

And thank you again for your hard work. I personally know it's not easy re-implementing such a fundamental part of the website.

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

@garbas garbas requested a review from samueldr July 29, 2020 20:18
demo.scenario Outdated Show resolved Hide resolved
Copy link
Member

@samueldr samueldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't believe we should change until all the blockers are fixed, or at the very least fully investigated and found to not be possible at all.

@garbas garbas requested a review from samueldr August 14, 2020 15:35
@garbas
Copy link
Member Author

garbas commented Aug 14, 2020

Blockers were now fixed

@github-actions
Copy link
Contributor

@github-actions
Copy link
Contributor

🚀 Deployed on https://5f3e35799c6a82b19884e999--nixos-homepage.netlify.app

@garbas garbas merged commit 1e059f8 into master Aug 20, 2020
@garbas garbas deleted the integrate-new-search branch August 20, 2020 08:35
@06kellyjac
Copy link
Member

Note for people stumbling over this PR from other issues:
This changed search is now located at https://search.nixos.org/packages (https://search.nixos.org/ will redirect there too) and you should be auto redirected there from the old https://nixos.org/nixos/packages.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment