Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cassowary: 0.7.0 -> 0.10.0 #89452

Closed
wants to merge 1 commit into from
Closed

cassowary: 0.7.0 -> 0.10.0 #89452

wants to merge 1 commit into from

Conversation

imalsogreg
Copy link
Contributor

Motivation for this change

Update cassowary, the http load testing tool, to 0.10.0. This version introduces a feature for testing POST endpoints.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from kalbasit and HugoReeves June 4, 2020 02:47
HugoReeves
HugoReeves approved these changes Jun 4, 2020
View reviewed changes
Copy link
Member

@HugoReeves HugoReeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unable to build & test right now, however the changes look correct. LGTM

@imalsogreg
Copy link
Contributor Author

imalsogreg commented Jun 4, 2020 •
edited

For reference, I built and tested this cassowary derivation on nixos, using it to load test a server with the new --postdata feature I was interested in. It looks 👍

@HugoReeves
Copy link
Member

Closing as v0.11 has been merged in #90315

@HugoReeves HugoReeves closed this Jun 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HugoReeves HugoReeves HugoReeves approved these changes

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@imalsogreg @HugoReeves