New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildbot: 2.7.0 -> 2.8.0 #89504
buildbot: 2.7.0 -> 2.8.0 #89504
Conversation
# 2.8.0 has broken tests: https://github.com/buildbot/buildbot/pull/5322 | ||
doCheck = !stdenv.isAarch64 && version != "2.8.0"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would rather just checkout source if that's not too much of an issue. Or give upstream some time to issue a patch update
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated the derivation to use fetchFromGitHub
, and linked to the PR above the call to it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this; I've been meaning to do it but have been busy. I haven't tested it, but this LGTM.
Whatever you want to do about the broken tests is fine with me. It's not the first time this same bug has happened, and in the past I think we just disabled the tests until it was fixed.
``` Bug fixes Fix GitHubEventHandler to include files in Change that comes from a github PR (issue # 5294) Updated the Docker container buildbot-master to Alpine 3.11 to fix segmentation faults caused by an old version of musl Base64 encoding logs and attachments sent via email so emails conform to RFC 5322 2.1.1 Handling the case where the BitbucketStatusPush return code is not 200 When cancelling a buildrequest, the reason field is now correctly transmitted all the way to the cancelled step. Fix Cache-control header to be compliant with RFC 7234 (issue # 5220) Fix GerritEventLogPoller class to be declared as entry_point (can be used in master.cfg file) Git poller: add –ignore-missing argument to git log call to avoid fatal: bad object errors Log watcher looks for the “tail” utility in the right location on Haiku OS. Add limit and filtering support for the changes data API as described in issue # 5207 Improved Documentation Make docs build with the latest sphinx and improve rendering of the example HTML file for custom dashboard Make docs build with Sphinx 3 and fix some typos and incorrect Python module declarations Features Property and Interpolate objects can now be compared. This will generate a renderable that will be evaluated at runtime. see Renderable Comparison. Added argument count to lock access to allow a lock to consume a variable amount of units Added arguments pollRandomDelayMin and pollRandomDelayMax to HgPoller, GitPoller, P4Poller, SvnPoller to spread the polling load ```
I pushed a new version fetching the sources from GitHub. I'd rather see passing tests ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/89504
7 packages failed to build:
buildbot buildbot-full buildbot-ui python27Packages.buildbot-worker python38Packages.buildbot python38Packages.buildbot-full python38Packages.buildbot-ui
14 packages built:
buildbot-worker python37Packages.buildbot-pkg python37Packages.buildbot-plugins.console-view python37Packages.buildbot-plugins.grid-view python37Packages.buildbot-plugins.waterfall-view python37Packages.buildbot-plugins.wsgi-dashboards python37Packages.buildbot-plugins.www python38Packages.buildbot-pkg python38Packages.buildbot-plugins.console-view python38Packages.buildbot-plugins.grid-view python38Packages.buildbot-plugins.waterfall-view python38Packages.buildbot-plugins.wsgi-dashboards python38Packages.buildbot-plugins.www python38Packages.buildbot-worker
Motivation for this change
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)