Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gstreamer: Fix wrapper quoting #89503

Merged
merged 1 commit into from Jun 13, 2020
Merged

gstreamer: Fix wrapper quoting #89503

merged 1 commit into from Jun 13, 2020

Conversation

andersk
Copy link
Contributor

@andersk andersk commented Jun 4, 2020

Motivation for this change

The bug was that the inner double quotes in "\$("…")" are not actually inner like they would be in "$("…")". We could write "\$(\"…\")", but using single quotes on the outside makes everything simpler.

Fixes #63751.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@andersk
gstreamer: Fix wrapper quoting
c235b54 
The bug was that the inner double quotes in "\$("…")" are not actually
inner like they would be in "$("…")".  We could write "\$(\"…\")", but
using single quotes on the outside makes everything simpler.

Fixes NixOS#63751.

Signed-off-by: Anders Kaseorg <andersk@mit.edu>
@ofborg ofborg bot requested review from ttuegel and matthewbauer June 4, 2020 21:08
@FRidh FRidh changed the base branch from master to staging June 13, 2020 09:01
@FRidh FRidh merged commit c8d064e into NixOS:staging Jun 13, 2020
@nh2
Copy link
Contributor

nh2 commented Jun 19, 2020

Thanks!

@andersk andersk deleted the gstreamer-quoting branch December 26, 2022 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ttuegel ttuegel Awaiting requested review from ttuegel

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
10.rebuild-darwin: 101-500 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

gst-launch-1.0 prints printf usage on run
3 participants
@andersk @nh2 @FRidh