Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.pytest-rerunfailures: 8.0 -> 9.0 #89514

Closed
wants to merge 2 commits into from
Closed

python3Packages.pytest-rerunfailures: 8.0 -> 9.0 #89514

wants to merge 2 commits into from

Conversation

das-g
Copy link
Member

@das-g das-g commented Jun 4, 2020

fixes #89508

  • bump pytest-rerunfailures to 9.0
  • drop Python 2.7 support for pytest-rerunfailures, because upstream did
  • drop Python ≤3.4 support for pytest-rerunfailures, because upstream did (in 8.0 already)
  • add myself (@das-g) as maintainer
Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
    • (there are none)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
    • (meta.description is not capitalized. Should it really?)

Result of nixpkgs-review 1

3 packages built:
- python37Packages.pytest-rerunfailures
- python38Packages.pytest-rerunfailures
- xonsh

@nixos-discourse
Copy link

This pull request has been mentioned on NixOS Discourse. There might be relevant details there:

https://discourse.nixos.org/t/prs-ready-for-review/3032/184

@jonringer
Copy link
Contributor

I cherry-picked these to #89723

@jonringer jonringer closed this Jun 12, 2020
@jonringer
Copy link
Contributor

35a6dc6 f0cf892

@das-g
Copy link
Member Author

das-g commented Jun 13, 2020 •
edited

@jonringer

Is there any reason to not (also) merge this to master? It's tested and it fixes a build failure that blocks another package (xonsh), than IMHO shouldn't have to wait until python-unstable is being merged to master, even if that were soon.

@jonringer
Copy link
Contributor

I wanted to reduce the number of merge conflicts @FRidh had to encounter on staging

@das-g
Copy link
Member Author

das-g commented Jun 13, 2020

@jonringer I doubt this change will cause merge conflicts, so please consider merging it to master. If it later turns out that it does in fact cause merge conflicts, I'm willing to help resolve them.

@das-g das-g reopened this Jun 13, 2020
@ofborg ofborg bot removed the 8.has: changelog label Jun 13, 2020
@das-g
Copy link
Member Author

das-g commented Jun 19, 2020

35a6dc6 & f0cf892 have now been merged to master. Closing.

@das-g das-g closed this Jun 19, 2020
@das-g das-g deleted the pytest-rerunfailures-9 branch June 19, 2020 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh Awaiting requested review from FRidh

@jonringer jonringer Awaiting requested review from jonringer

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

python3Packages.pytest-rerunfailures doesn't build due to failed tests
3 participants
@das-g @nixos-discourse @jonringer