Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue #295 keep circles to 16 edges minimum. #626

Merged
merged 3 commits into from Jun 12, 2020

Conversation

phkahler
Copy link
Member

@phkahler phkahler commented Jun 4, 2020

No description provided.

@whitequark
Copy link
Contributor

whitequark commented Jun 4, 2020

Code looks reasonable, do you think you could post some before/after? I'll check it out locally and play with it a bit later to see how this works out with different models.

@phkahler
Copy link
Member Author

phkahler commented Jun 5, 2020

Before: even at this level holes look bad:
Before
After: much smaller hole diameter zoomed in:
After
With this change, people shouldn't be changing chord tolerance just to prevent octagons. When the holes look bad, any other curves will too, and changing tolerance should be the right thing to do. Also good for those smallish rounded corners.

@phkahler phkahler linked an issue Jun 12, 2020 that may be closed by this pull request
@phkahler phkahler merged commit 053f649 into solvespace:master Jun 12, 2020
@phkahler phkahler deleted the triangles branch June 15, 2020 00:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circle rendering is very conservative
2 participants