Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

factorio{,-headless}-experimental: 0.18.29 -> 0.18.30 #89467

Merged
merged 1 commit into from Jun 9, 2020

Conversation

priegger
Copy link
Contributor

@priegger priegger commented Jun 4, 2020

Motivation for this change

Update factorio experimental to the latest version.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Copy link
Member

@erictapen erictapen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds for me.

@priegger priegger changed the title factorio{,-headless}-experimental: 0.18.29 -> 0.18.30 factorio{,-headless}-experimental: 0.18.29 -> 0.18.30, factorio-demo-experimental: init at 0.18.30 Jun 8, 2020
@priegger
Copy link
Contributor Author

priegger commented Jun 8, 2020

I also added factorio-demo-experimental.

@erictapen
Copy link
Member

@priegger Builds fine, but when I run the experimental demo and start a tutorial, I get this error:

  34.203 Error AppManager.cpp:640: Error while running reload_script: filesystem error: copy_file "/nix/store/a78qwkia1dr8h2akq7lsijnw9dy665h1-factorio-demo-0.18.30/share/factorio/data/base/campaigns/tutorial/lualib/new-hope-util.lua" to "/home/justin/.factorio/temp/currently-playing/new-hope-util.lua" failed: Permission denied [/nix/store/a78qwkia1dr8h2akq7lsijnw9dy665h1-factorio-demo-0.18.30/share/factorio/data/base/campaigns/tutorial/lualib/new-hope-util.lua] [/home/justin/.factorio/temp/currently-playing/new-hope-util.lua]

I guess this is due to state in my home directory, but could you verify that you can start a tutorial in the demo? If yes I'll approve the PR, wouldn't need to to test it myself in this case.

@priegger
Copy link
Contributor Author

priegger commented Jun 8, 2020

@erictapen: Thanks a lot, I missed this problem.

I cannot start the tutorial in the demo. I think the problem is, that files from factorio get copied into the user home and then cannot be changed anymore. The current non-experimental (0.17.79) factorio-demo has the same problem.

I now remember, I also saw this before in the non-demo factorio version. I hacked around it with a "while true; chmod ug+w .factorio; done" or something like that.

Might be related to #39807.

I guess I just drop that commit and don't add a (broken) factorio-demo-experimental for now.

@priegger priegger changed the title factorio{,-headless}-experimental: 0.18.29 -> 0.18.30, factorio-demo-experimental: init at 0.18.30 factorio{,-headless}-experimental: 0.18.29 -> 0.18.30 Jun 8, 2020
@NickHu NickHu merged commit de94d7a into NixOS:master Jun 9, 2020
@priegger priegger deleted the fix/factorio-0.18.30 branch June 15, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants