sed-opal-unlocker: init at 1.0.0 #89518
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
jonringer
reviewed
Jul 30, 2020
| # in case someone wants to embed this in an initramfs or PBA image. | ||
| sedutil-passhasher = stdenv.mkDerivation { | ||
| inherit version src; | ||
| name = "sedutil-passhasher"; |
There was a problem hiding this comment.
Suggested change
| name = "sedutil-passhasher"; | |
| pname = "sedutil-passhasher"; |
|
|
||
| sed-opal-unlocker = stdenv.mkDerivation { | ||
| inherit version src; | ||
| name = "sed-opal-unlocker"; |
There was a problem hiding this comment.
Suggested change
| name = "sed-opal-unlocker"; | |
| pname = "sed-opal-unlocker"; |
Comment on lines
+24
to
+25
| sedutil-passhasher = stdenv.mkDerivation { | ||
| inherit version src; |
There was a problem hiding this comment.
if someone is expected to use this separately, you could make a separate file and just do:
{ ... , sed-opal-unlocker }:
stdenv.mkDerivation {
inherit (sed-opal-unlocker) version src;
pname = ...;
...
| }; | ||
|
|
||
| sed-opal-unlocker = stdenv.mkDerivation { | ||
| inherit version src; |
There was a problem hiding this comment.
Suggested change
| inherit version src; | |
| inherit version src meta; |
| # generate a password hash. This keeps python3 out of the main closure, | ||
| # in case someone wants to embed this in an initramfs or PBA image. | ||
| sedutil-passhasher = stdenv.mkDerivation { | ||
| inherit version src; |
There was a problem hiding this comment.
Suggested change
| inherit version src; | |
| inherit version src meta; |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing because author did not respond in the last months. Feel free to reopen the discussion. |
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Add sed-opal-unlocker, a tiny utility program to unlock self-encrypting drives using the TGC OPAL standard.
I have been using this for around a year now to unlock my laptop drive when resuming from hibernation, using
powerManagement.powerUpCommands, and it's solid.I split out the
sedutil-passhasherscript to a passthru derivation as it's only needed once to generate the password hash, and python doesn't need to be in the closure just to unlock a drive.Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)