Make PathInput plugin cache validity configurable #775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PathInput plugin keeps a cache of path evaluations. This cache is simple, and path is not checked more than once every N seconds, where N=30. The caching is there to avoid expensive calls to `nix-store --add`. This change makes the validity period configurable. The main use case is `api-test.pl` which was implemented wrong for a while, as the invocation of `hydra-eval-jobset` would return the previous evaluation, claiming there are no changes. The test has been fixed to check better for a new evaluation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PathInput plugin keeps a cache of path evaluations. This cache is simple, and
path is not checked more than once every N seconds, where N=30. The caching is
there to avoid expensive calls to
nix-store --add.This change makes the validity period configurable. The main use case is
api-test.plwhich was implemented wrong for a while, as the invocation ofhydra-eval-jobsetwould return the previous evaluation, claiming there are nochanges. The test has been fixed to check better for a new evaluation.