pythonPackages.wtforms: 2.1 -> 2.3.1 #89507
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Result of 1 package marked as broken and skipped:- python27Packages.flask-openid 9 packages failed to build:- apache-airflow (python37Packages.apache-airflow) - buku - python27Packages.flask-admin - python27Packages.ihatemoney - python37Packages.flask-admin - python37Packages.ihatemoney - python38Packages.apache-airflow - python38Packages.flask-admin - python38Packages.ihatemoney 16 packages built:- etesync-dav - python27Packages.flask-mongoengine - python27Packages.flask_ldap_login - python27Packages.flask_wtf - python27Packages.wtf-peewee - python27Packages.wtforms - python37Packages.flask-appbuilder - python37Packages.flask-mongoengine - python37Packages.flask_wtf - python37Packages.wtf-peewee - python37Packages.wtforms - python38Packages.flask-appbuilder - python38Packages.flask-mongoengine - python38Packages.flask_wtf - python38Packages.wtf-peewee - python38Packages.wtforms |
jonringer
approved these changes
Jun 4, 2020
There was a problem hiding this comment.
LGTM
failures are broken on target branch
https://github.com/NixOS/nixpkgs/pull/89507
9 packages failed to build:
apache-airflow buku python27Packages.flask-admin python27Packages.ihatemoney python37Packages.flask-admin python37Packages.ihatemoney python38Packages.apache-airflow python38Packages.flask-admin python38Packages.ihatemoney
16 packages built:
etesync-dav python27Packages.flask-mongoengine python27Packages.flask_ldap_login python27Packages.flask_wtf python27Packages.wtf-peewee python27Packages.wtforms python37Packages.flask-appbuilder python37Packages.flask-mongoengine python37Packages.flask_wtf python37Packages.wtf-peewee python37Packages.wtforms python38Packages.flask-appbuilder python38Packages.flask-mongoengine python38Packages.flask_wtf python38Packages.wtf-peewee python38Packages.wtforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2.1 is from 2015!
https://github.com/wtforms/wtforms/blob/master/CHANGES.rst
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)