haskellPackages.c2hsc: apply patchto find gcc #89488
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdepillabout
requested changes
Jun 5, 2020
cdepillabout
reviewed
Jun 6, 2020
| # waiting for release: https://github.com/jwiegley/c2hsc/issues/41 | ||
| c2hsc = appendPatch super.c2hsc (pkgs.fetchpatch { | ||
| url = "https://github.com/jwiegley/c2hsc/commit/490ecab202e0de7fc995eedf744ad3cb408b53cc.patch"; | ||
| sha256 = "0z0x6jsf7jz32kmjxp077h0ca98hwjyx16kpk9660id7ikmbcz91"; |
There was a problem hiding this comment.
Hmm, I appear to be getting a different hash for this:
$ nix-build -A haskellPackages.c2hsc --arg config '{allowBroken=true;}'
these derivations will be built:
/nix/store/b2q7nszrzi629nk1f79jsiya2yv8f1dg-490ecab202e0de7fc995eedf744ad3cb408b53cc.patch.drv
/nix/store/07llqlbz5b5jjhyxlkwiv82banp4c0dm-c2hsc-0.7.1.drv
building '/nix/store/b2q7nszrzi629nk1f79jsiya2yv8f1dg-490ecab202e0de7fc995eedf744ad3cb408b53cc.patch.drv'...
trying https://github.com/jwiegley/c2hsc/commit/490ecab202e0de7fc995eedf744ad3cb408b53cc.patch
% Total % Received % Xferd Average Speed Time Time Time Current
Dload Upload Total Spent Left Speed
100 1797 100 1797 0 0 18525 0 --:--:-- --:--:-- --:--:-- 18525
hash mismatch in fixed-output derivation '/nix/store/ilq40b6a9k2n53ch5pikz39wn4xpfsx9-490ecab202e0de7fc995eedf744ad3cb408b53cc.patch':
wanted: sha256:0z0x6jsf7jz32kmjxp077h0ca98hwjyx16kpk9660id7ikmbcz91
got: sha256:1c7knpvxr7p8c159jkyk6w29653z5yzgjjqj11130bbb8mk9qhq7
cannot build derivation '/nix/store/07llqlbz5b5jjhyxlkwiv82banp4c0dm-c2hsc-0.7.1.drv': 1 dependencies couldn't be built
error: build of '/nix/store/07llqlbz5b5jjhyxlkwiv82banp4c0dm-c2hsc-0.7.1.drv' failedThere was a problem hiding this comment.
not sure what's wrong nix-build -A haskellPackages.c2hsc --arg config '{allowBroken=true;}' --check builds corerclty plus
nix-prefetch-url https://github.com/jwiegley/c2hsc/commit/490ecab202e0de7fc995eedf744ad3cb408b53cc.patch ~/nixpkgs3
path is '/nix/store/d2n0i5i9132pw5ijvg9lirxvnw17y5i7-490ecab202e0de7fc995eedf744ad3cb408b53cc.patch'
0z0x6jsf7jz32kmjxp077h0ca98hwjyx16kpk9660id7ikmbcz91
|
@GrahamcOfBorg build haskellPackages.c2hsc |
|
ofc it won't evalluate since the package set was not regenerated, I sure hope we can get sthg like #62105 before next release. |
|
@GrahamcOfBorg build haskellPackages.c2hsc |
|
@GrahamcOfBorg build haskellPackages.c2hsc |
peti
force-pushed
the
haskell-updates
branch
3 times, most recently
from
6d394ab
to
7325cc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...used in tests.
Fix is upstream but there has been no sign of release for the past 6
months, fixes #63764.
I might need to remove it from the list of borken packages, is that correct ?
Motivation for this change
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)