Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.rollup: init #89509

Closed
wants to merge 1 commit into from
Closed

nodePackages.rollup: init #89509

wants to merge 1 commit into from

Conversation

tuedel
Copy link
Contributor

@tuedel tuedel commented Jun 4, 2020

Motivation for this change

rollup not available in nixpkgs.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@WilliButz 馃槈

@tuedel tuedel changed the title nodePackages: Add rollup and regenerate set nodePackages.rollup: init at 2.13 Jun 4, 2020
@veprbl
Copy link
Member

veprbl commented Jun 5, 2020

Please don't regenerate node-packages.nix yourself, there is still an open question whether we can take base64 hashes: #89520.

@tuedel
Copy link
Contributor Author

tuedel commented Jun 5, 2020

Thanks for the hint!
Updated, this only adds a single line in node-packages.json now.

@tuedel tuedel changed the title nodePackages.rollup: init at 2.13 nodePackages.rollup: init Jun 5, 2020
@veprbl veprbl self-assigned this Jun 8, 2020
@veprbl
Copy link
Member

veprbl commented Jun 9, 2020

Landed in 43adf0c

@veprbl veprbl closed this Jun 9, 2020
@veprbl veprbl removed their assignment Jun 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 0 10.rebuild-linux: 0 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tuedel @veprbl @Janik-Haag