Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "python3Packages.shellingham: 1.3.1 -> 1.3.2" #89475

Closed
wants to merge 1 commit into from

Conversation

moritzschaefer
Copy link
Contributor

This reverts commit e36caa1.

Motivation for this change

As described in #89448, the automatic upgrade to shellingham broke the package. The pypi-tarball of version 1.3.2 does not contain setup.py, which is however required for building the package.

Things done
  • checked presence (and absence) of setup.py in tarballs of version 1.3.1 and 1.3.2
  • run nix-build -A python37Packages.shellingham
  • using NixOS

After reverting, the package builds as expected.

@FRidh
Copy link
Member

FRidh commented Jun 4, 2020

I would much more prefer an actual fix for 1.3.2 than taking the easy way out and revert.

A quick look at the contents of the tarball shows this package is PEP 517 compatible, so passing format = "pyproject"; should fix the issue.

Note this is the new standard in Python packaging and that in the future it will also be the new default in buildPython*.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants