Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While playing around with Nix master, I realized that the log-prefix is
broken when building a derivation on a remote builder:
It seems as the five chars of the string
hello
have been replaced bythe builder's name (ssh://builder). I suspect that this is related to
fmt
takingargs
as reference[1].I'm not sure why, but this can be avoided by not appending another
formatted string to
i->s
. I worked around this by modifyingi->s
only once.
I can reproduce this on a recent
master
[2] and on a recentflakes
[3]. Inthe latter case, e.g.
nix flake check -L
is also affected.[1] 334b8f8
[2] bfa1acd
[3] 81cafda