Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.gast_0_2_2: init for tensorflow #89496

Closed
wants to merge 1 commit into from
Closed

pythonPackages.gast_0_2_2: init for tensorflow #89496

wants to merge 1 commit into from

Conversation

matthewbauer
Copy link
Member

It’s been reported that python-gast-0.2.2 is needed for Tensorflow
Autograph. See tensorflow/tensorflow#38734.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
pythonPackages.gast_0_2_2: init for tensorflow
32ea29b 
It’s been reported that python-gast-0.2.2 is needed for Tensorflow
Autograph. See tensorflow/tensorflow#38734.
@jonringer
Copy link
Contributor

The link you provided just shows an install error. Is there a runtime error with using gast>=0.3?

Generally we try to avoid different versions in python-modules as this will create incoherent package sets if a user creates an envrionment with 2 different versions of the same package.

@ofborg ofborg bot requested review from cdepillabout and abbradar June 4, 2020 18:42
@matthewbauer
Copy link
Member Author

A better description of the issue is here:

tensorflow/tensorflow#32319

jonringer
jonringer reviewed Jun 4, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @FRidh

pkgs/development/python-modules/gast/0_2_2.nix Show resolved Hide resolved
pkgs/development/python-modules/gast/0_2_2.nix Show resolved Hide resolved
pkgs/development/python-modules/gast/0_2_2.nix Show resolved Hide resolved
@jmillerpdt jmillerpdt mentioned this pull request Jul 14, 2020
Closed
FRidh
FRidh requested changes Jul 31, 2020
View reviewed changes
Copy link
Member

@FRidh FRidh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No this is not possible. We cannot have multiple versions of packages because this will cause runtime conflicts when mixing packages relying on the different versions.

@FRidh
Copy link
Member

FRidh commented Jul 31, 2020 •
edited

Simply put, the older tensorflow will no longer work with Nixpkgs, unless the user themselves performs an override to fix it, thereby breaking other packages in the package set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh FRidh requested changes

@Ericson2314 Ericson2314 Awaiting requested review from Ericson2314

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

@abbradar abbradar Awaiting requested review from abbradar

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewbauer @jonringer @FRidh