Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python3Packages.shellingham: use pyproject format #89497

Merged
merged 2 commits into from Jun 5, 2020

Conversation

jonringer
Copy link
Contributor

@jonringer jonringer commented Jun 4, 2020

Motivation for this change

closes #89475 #89448

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

```
ERROR: Package 'togglCli' requires a different Python: 3.8.2 not in '>=3.5.0, <3.8.0'
```
@ofborg ofborg bot requested a review from mmahut June 4, 2020 19:16
@jonringer
Copy link
Contributor Author

failures broken on target branch:

https://github.com/NixOS/nixpkgs/pull/89497
1 package failed to build:
python27Packages.poetry

14 packages built:
cmake-language-server doitlive python27Packages.shellingham python37Packages.aria2p python37Packages.click-completion python37Packages.poetry python37Packages.shellingham python37Packages.toggl-cli python37Packages.xdg python38Packages.aria2p python38Packages.click-completion python38Packages.poetry python38Packages.shellingham python38Packages.xdg

@jonringer jonringer merged commit b6a43d6 into NixOS:master Jun 5, 2020
@jonringer jonringer deleted the fix-shellingham branch June 5, 2020 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant