Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gitlab: 12.10.8 -> 13.0.4 #89480

Merged
merged 2 commits into from Jun 5, 2020
Merged

gitlab: 12.10.8 -> 13.0.4 #89480

merged 2 commits into from Jun 5, 2020

Conversation

talyz
Copy link
Contributor

@talyz talyz commented Jun 4, 2020

Motivation for this change

Update GitLab to major version 13.

https://about.gitlab.com/releases/2020/05/22/gitlab-13-0-released/
https://about.gitlab.com/releases/2020/05/27/security-release-13-0-1-released/
https://about.gitlab.com/releases/2020/05/29/gitlab-13-0-3-released/
https://about.gitlab.com/releases/2020/06/03/critical-security-release-13-0-4-released/

The gitaly gitlab-shell config has moved into gitaly.toml. See https://gitlab.com/gitlab-org/gitaly/-/issues/2182 for more info.

Replaces #89239.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@talyz talyz requested review from flokli, globin and a user June 4, 2020 12:30
@talyz
Copy link
Contributor Author

talyz commented Jun 4, 2020

@GrahamcOfBorg test gitlab

@bgamari
Copy link
Contributor

bgamari commented Jun 20, 2020

Thank you for doing this, @talyz! I was very much dreading the prospect of having to puzzle through this myself.

@talyz talyz deleted the gitlab-13 branch June 16, 2021 07:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants