Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't enable nix-bash-completions when using Nix 2.4 #89479

Merged
merged 1 commit into from Jun 5, 2020
Merged

Don't enable nix-bash-completions when using Nix 2.4 #89479

merged 1 commit into from Jun 5, 2020

Conversation

edolstra
Copy link
Member

@edolstra edolstra commented Jun 4, 2020

Motivation for this change

Nix 2.4 has its own completion script which collides with nix-bash-completions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@edolstra
Don't enable nix-bash-completions when using Nix 2.4
bbfc473 
2.4 has its own completion script which collides with
nix-bash-completions.
@Izorkin
Copy link
Contributor

Izorkin commented Jun 4, 2020

Nix 2.4 does not conflict with nix-zsh-completions ?

@edolstra
Copy link
Member Author

edolstra commented Jun 5, 2020

No, it doesn't provide any zsh completion support.

@edolstra edolstra merged commit b00463d into NixOS:master Jun 5, 2020
@edolstra edolstra deleted the nix-2.4-completion branch June 5, 2020 11:29
@ncfavier ncfavier mentioned this pull request Jun 19, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@edolstra @Izorkin