Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fatsort: 1.5.0.456 -> 1.6.2.605 #87534

Merged
merged 1 commit into from May 10, 2020
Merged

fatsort: 1.5.0.456 -> 1.6.2.605 #87534

merged 1 commit into from May 10, 2020

Conversation

bjornfor
Copy link
Contributor

Motivation for this change

New version.

The patch to set PREFIX needed updating to apply. Rewrite it in a way
that allows submitting upstream. That means we don't hardcode
PREFIX=$out inside the patch but allow the PREFIX to be passed to make
at build time.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bjornfor
fatsort: 1.5.0.456 -> 1.6.2.605
66f90b8 
The patch to set PREFIX needed updating to apply. Rewrite it in a way
that allows submitting upstream. That means we don't hardcode
PREFIX=$out inside the patch but allow the PREFIX to be passed to make
at build time.
@ofborg ofborg bot requested a review from KoviRobi May 10, 2020 19:51
@marsam marsam merged commit 830711d into NixOS:master May 10, 2020
@bjornfor bjornfor deleted the update-fatsort branch May 11, 2020 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KoviRobi KoviRobi KoviRobi approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bjornfor @KoviRobi @marsam