Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

oq: 1.0.2 -> 1.1.0, fix build #87504

Merged
merged 2 commits into from May 10, 2020
Merged

oq: 1.0.2 -> 1.1.0, fix build #87504

merged 2 commits into from May 10, 2020

Conversation

stigtsp
Copy link
Member

@stigtsp stigtsp commented May 10, 2020 •
edited

Version bumped 1.0.2 -> 1.1.0

Fixes build failure

  • Set build format explicitly to crystal since buildCrystalPackage thinks it's make
  • Copy binary to bin/oq for tests to run.
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@stigtsp stigtsp requested review from Br1ght0ne and etu May 10, 2020 15:00
@stigtsp stigtsp changed the title oq: fix build oq: 1.0.2 -> 1.1.0, fix build May 10, 2020
@etu etu merged commit e7b5f78 into NixOS:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Br1ght0ne Br1ght0ne Awaiting requested review from Br1ght0ne

@etu etu Awaiting requested review from etu

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@stigtsp @etu