realsense + examples + udev rules #87503
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nixos module providing udev rules
doronbehar
requested changes
Sep 11, 2020
| hardware.intel.realsense.enable = mkOption { | ||
| type = types.boolean; | ||
| default = false; | ||
| description = '' Enable (intel) librealsense udev rules ''; |
There was a problem hiding this comment.
Suggested change
| description = '' Enable (intel) librealsense udev rules ''; | |
| description = '' | |
| Enable (intel) librealsense udev rules | |
| ''; |
| chmod +x $udev_bins_path/* | ||
| cp config/99-realsense-libusb.rules $out/lib/udev/rules.d/99-realsense-libusb.rules | ||
| sed -i -e "s@/usr/local/bin/\\(usb-R200-in_udev\\|usb-R200-in\\)@$udev_bins_path/\\1@" -e "s@/bin/sh@$(type -p sh)@" $udev_bins_path/* $out/lib/udev/rules.d/99-realsense-libusb.rules | ||
| ''; |
There was a problem hiding this comment.
This is good. Please open an issue upstream, fix indentation, and link in a comment here to the issue upstream.
| }: | ||
|
|
||
| # See ./nixos/modules/hardware/intel-realsense.nix's option to also get udev rules | ||
| # TODO: turn buildExamples into multi output derivation |
There was a problem hiding this comment.
I'd advise to do this before we'd continue the review.
| hardware.intel.realsense.package = mkOption { | ||
| type = types.package; | ||
| default = pkgs.librealsenseWithExamples; | ||
| description = '' use pkgs.librealsense to avoid examples. The examples for instance contain realsense-viewer.''; |
There was a problem hiding this comment.
Suggested change
| description = '' use pkgs.librealsense to avoid examples. The examples for instance contain realsense-viewer.''; | |
| description = '' | |
| The librealsense package to use. | |
| ''; | |
| example = pkgs.librealsenseWithCuda; |
|
|
||
| hardware.intel.realsense.package = mkOption { | ||
| type = types.package; | ||
| default = pkgs.librealsenseWithExamples; |
There was a problem hiding this comment.
Suggested change
| default = pkgs.librealsenseWithExamples; | |
| default = pkgs.librealsense; |
|
Note the merge conflicts. Also please check whether the examples by any chance retain references to |
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
No response to reviews and no compliance to https://github.com/NixOS/nixpkgs/blob/master/.github/CONTRIBUTING.md, closing. |
stale
bot
removed
the
2.status: stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
realsense-viewer still complains about udev rules being outdated cause it seems to byte compare with the patched version. But it seems to work.