Improve symbol tokenization. #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I can't remember why I put it there... this case seems to handle symbols, but we're already handling them.
|
Thanks! I completely screwed up that new test case. I see that there is an error in the test suite though. Any idea what those are from? |
`signum` is defined in `cl`, which is not required by `nix-mode`. I don't think the use of such a simple function warrants an additional import, so I decided to inline it.
|
The tests failed due to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#97 incorrectly handles multi-character symbols such as
==.This PR fixes #94 while correctly tokenizing multi-character symbols.