Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deluge: fix running the Gtk UI #87457

Merged
merged 1 commit into from May 10, 2020
Merged

deluge: fix running the Gtk UI #87457

merged 1 commit into from May 10, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented May 10, 2020 •
edited

Motivation for this change

At the moment, runing deluge with the deluge package installed returns
"No GSettings schemas are installed on the system".

After this patch, XDG_DATA_DIRS includes the gsettings-desktop-schemas,
which means the program actually manages to launch.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@lukegb
deluge: add glib so its hook works.
33811f9 
At the moment, runing `deluge` with the deluge package installed returns
"No GSettings schemas are installed on the system".

After this patch, XDG_DATA_DIRS includes the gsettings-desktop-schemas,
which means the program actually manages to launch.
@ofborg ofborg bot requested review from ebzzry and domenkozar May 10, 2020 01:16
@prusnak prusnak mentioned this pull request May 10, 2020
Merged
10 tasks
@bjornfor bjornfor merged commit 5da1393 into NixOS:master May 10, 2020
@lukegb lukegb deleted the fix/deluge-gsettings-schemas branch December 5, 2022 01:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor approved these changes

@ebzzry ebzzry Awaiting requested review from ebzzry

@domenkozar domenkozar Awaiting requested review from domenkozar

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@lukegb @bjornfor