Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP arduino core upgrade. #87479

Closed
wants to merge 3 commits into from
Closed

WIP arduino core upgrade. #87479

wants to merge 3 commits into from

Conversation

dasj19
Copy link
Contributor

@dasj19 dasj19 commented May 10, 2020

Motivation for this change

I would like to upgrade to latest arduino IDE but it still complains about missing libraries...

BUILD FAILED /build/source/build/build.xml:134: The following error occurred while executing this line: /build/source/build/build.xml:638: The following error occurred while executing this line: /build/source/build/build.xml:220: The following error occurred while executing this line: /build/source/build/build.xml:887: Could not find file /build/source/build/shared/WiFi101-Updater-ArduinoIDE-Plugin-0.10.10.zip to generate checksum for.

@cc bjornfor gazally bergey binarin worldofpeace
robberer matthewbauer
pSuborbekk jwiegley Ericson2314 witchof0x20 domenkozar cko auntieNeo abbradar

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested review from bjornfor and bergey May 10, 2020 10:21
@dasj19
Copy link
Contributor Author

dasj19 commented May 10, 2020

I fixed all the small typos and comments and I end with the following:
BUILD FAILED /build/source/build/build.xml:134: The following error occurred while executing this line: /build/source/build/build.xml:638: The following error occurred while executing this line: /build/source/build/build.xml:220: The following error occurred while executing this line: /build/source/build/build.xml:869: The following error occurred while executing this line: /build/source/build/build.xml:873: get doesn't support the "error" attribute

prusnak
prusnak requested changes May 10, 2020
View reviewed changes
Copy link
Member

@prusnak prusnak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You missed some of the updates, that's why the build is failing:

appbundler-1.0ea-arduino5 and maybe others, please go through build/build.xml and double-check if there is something else to fix.

pkgs/development/arduino/arduino-core/downloads.nix
url = "https://github.com/arduino-libraries/WiFi101-FirmwareUpdater-Plugin/archive/v0.10.10.zip";
sha256 = "1j6xy7ffrapk0brcfknaj72pvmzrf19sks8pm900ad7w897mksmv";
};
"build/libastylej-2.05.1-4.zip" = fetchurl {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was moved from its original location for no good reason. Move it back where it was - just before "build/liblistSerials"

Also update to libastylej-2.05.1-5 - you missed this update.

Copy link
Contributor Author

@dasj19 dasj19 May 11, 2020 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I updated the build package for the others archs.... I have to admit that I am a bit lost as to how I would continue... Idk how to browse downloads.arduino.cc FTP style... so I would not have to hunt down package names and version numbers

@prusnak
Copy link
Member

prusnak commented May 11, 2020 •
edited

There was much more that had to be done that it was easier to open a new pull request #87614

Thank you for your work @dasj19 and you are more than welcome to test and review the other PR!

@prusnak prusnak closed this May 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak requested changes

@bjornfor bjornfor Awaiting requested review from bjornfor

@bergey bergey Awaiting requested review from bergey

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dasj19 @prusnak