Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bazarr #87495

Merged
merged 3 commits into from May 22, 2020
Merged

Bazarr #87495

merged 3 commits into from May 22, 2020

Conversation

d-xo
Copy link
Contributor

@d-xo d-xo commented May 10, 2020

Motivation for this change

Adds a package and nixos module for https://github.com/morpheus65535/bazarr.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@d-xo
Copy link
Contributor Author

d-xo commented May 21, 2020

@bjornfor thanks for the review!

I made the following changes:

  • rebased on master
  • addressed review comments
  • added passthru.tests
  • added checks to only create bazarr user / group if required

@d-xo
Copy link
Contributor Author

d-xo commented May 22, 2020

bumped to 0.8.4.4

@bjornfor bjornfor merged commit 74bf0fa into NixOS:master May 22, 2020
@d-xo d-xo deleted the bazarr branch May 24, 2020 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants