Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python: coverage: 4.5.4 -> 5.1 #87430

Merged
merged 1 commit into from Jun 4, 2020
Merged

python: coverage: 4.5.4 -> 5.1 #87430

merged 1 commit into from Jun 4, 2020

Conversation

vojta001
Copy link
Contributor

@vojta001 vojta001 commented May 9, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

jonringer
jonringer reviewed May 11, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

since this change causes over 500 rebuilds, do you mind targeting the staging branch

git rebase --onto=origin/staging HEAD~1
git push .. ... --force

then change the base branch in the github PR from master -> staging

See https://nixos.org/nixpkgs/manual/#submitting-changes-staging-branch for more details on staging branch

@vojta001 vojta001 changed the base branch from master to staging May 12, 2020 16:08
@vojta001
Copy link
Contributor Author

Sorry, my fault. Rebased.

@vojta001
Copy link
Contributor Author

Is there any way one can check the number of rebuilds in advance?

@jonringer
Copy link
Contributor

You can do a nixpkgs-review wip (assuming your changes aren't committed yet), and it will say how many packages will be rebuilt

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.requests
@GrahamcOfBorg build python38Packages.requests

@jonringer
Copy link
Contributor

looks like there's a major regression with cffi in staging right now

@FRidh
Copy link
Member

FRidh commented Jun 4, 2020

This update should be fine by now. If it turns out it breaks (too many) Python packages, we revert in staging-next.

@FRidh FRidh merged commit d2d0700 into NixOS:staging Jun 4, 2020
@vojta001 vojta001 deleted the python-coverage branch February 17, 2021 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer jonringer left review comments

@FRidh FRidh Awaiting requested review from FRidh

@LnL7 LnL7 Awaiting requested review from LnL7

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vojta001 @jonringer @FRidh