mlflow-server: support additional packages for other database backends #87428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bhipple
requested changes
May 10, 2020
| @@ -10,7 +10,8 @@ py.toPythonApplication | |||
| propagatedBuildInputs = old.propagatedBuildInputs ++ [ | |||
| py.boto3 | |||
| py.mysqlclient | |||
| ]; | |||
| py.psycopg2 | |||
| ] ++ additionalPackages; | |||
There was a problem hiding this comment.
This seems unnecessary, since you can just take the resulting python application and call it with overrideAttrs to add more propagatedBuildInputs without the extra hook, right?
There was a problem hiding this comment.
I thought so too, but didn't work:
mlflow-server = super.mlflow-server.overrideAttrs (old: rec {
propagatedBuildInputs = old.propagatedBuildInputs ++ [
super.python3.packages.psycopg2
];
});
I also tried an overlay for mlflow, but didn't work either.
There was a problem hiding this comment.
I think it’s a quirk of toPythonApplication, but maybe I made a bonehead mistake
There was a problem hiding this comment.
you may have to do overridePythonAttrs, I'm honestly not sure what the difference is
|
I marked this as stale due to inactivity. → More info |
stale
bot
added
the
2.status: stale
|
Closing as this can be easily done in configuration.nix. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
add postgres backend, make easier for user to add their own preferred.
Things done
sandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)