Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

obs-studio-plugins.input-overlay: init at 5.0.0 #87521

Merged
merged 1 commit into from Nov 13, 2022
Merged

obs-studio-plugins.input-overlay: init at 5.0.0 #87521

merged 1 commit into from Nov 13, 2022

Conversation

glittershark
Copy link
Member

@glittershark glittershark commented May 10, 2020 •
edited

Motivation for this change

OBS plugin for displaying keyboard inputs

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS (just libuiohook, not obs-input-overlay, because obs-studio itself isn't supported on darwin)
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@glittershark glittershark marked this pull request as draft July 9, 2020 20:47
@stale
Copy link

stale bot commented Jan 6, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 6, 2021
@glittershark
Copy link
Member Author

finally a stalebot label that's actually helpful.

if anyone finds this and wants it, let me know

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 6, 2021
@jansol
Copy link
Contributor

jansol commented Jun 5, 2021

In case someone picks this up, it should probably be made compatible with the plugin wrapper introduced in #125308

@stale
Copy link

stale bot commented Jan 9, 2022

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jan 9, 2022
@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Nov 11, 2022
@fpletz fpletz marked this pull request as ready for review November 11, 2022 04:12
@fpletz fpletz changed the title obs-input-overlay: init at 4.8 obs-studio-plugins.input-overlay: init at 4.8 Nov 11, 2022
@fpletz
Copy link
Member

fpletz commented Nov 11, 2022

Updated the package and adapted to the obs-plugins abstraction.

@fpletz fpletz changed the title obs-studio-plugins.input-overlay: init at 4.8 obs-studio-plugins.input-overlay: init at 5.0.0 Nov 11, 2022
@fpletz fpletz requested a review from SebTM November 11, 2022 04:14
@SebTM
Copy link
Contributor

SebTM commented Nov 11, 2022 •
edited

The PR is missing a compatible version for OBS27 based on the new multi-version support added with upgrade to OBS28 in master -> https://github.com/univrsal/input-overlay/releases/tag/v5.0.0 (possibly irrelevant because of #200639 (comment))

Built and tested against #200639

@fpletz
Copy link
Member

fpletz commented Nov 11, 2022

The PR is missing a compatible version for OBS27 based on the new multi-version support added with upgrade to OBS28 in master -> univrsal/input-overlay@v5.0.0 (release) (possibly irrelevant because of #200639 (comment))

OBS27 was removed in the mentioned PR.

@glittershark @fpletz
obs-studio-plugins.input-overlay: init at 5.0.0
005798c 
Co-authored-by: Franz Pletz <fpletz@fnordicwalking.de>
@fpletz fpletz merged commit 9c3248f into NixOS:master Nov 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz left review comments

@SebTM SebTM SebTM approved these changes

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@glittershark @jansol @fpletz @SebTM