Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

mesa: make more things optional #87438

Merged
merged 2 commits into from May 30, 2020
Merged

mesa: make more things optional #87438

merged 2 commits into from May 30, 2020

Conversation

matthewbauer
Copy link
Member

osmesa & gallium-nine are not needed for all systems. So this adds a
flag to disable them if you don’t want them.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
mesa: make more things optional
0048f3e 
osmesa & gallium-nine are not needed for all systems. So this adds a
flag to disable them if you don’t want them.
@ofborg ofborg bot requested a review from vcunat May 9, 2020 22:09
@matthewbauer matthewbauer changed the base branch from master to staging May 9, 2020 22:11
@Atemu
Copy link
Member

Atemu commented May 23, 2020

What's up with all the unrelated commits?

@matthewbauer matthewbauer changed the base branch from staging to master May 23, 2020 23:31
@matthewbauer matthewbauer changed the base branch from master to staging May 23, 2020 23:31
@matthewbauer
Copy link
Member Author

What's up with all the unrelated commits?

Github can get out of date if you change from master to staging. Staging should have all of master’s commits but they get out of date over time.

@matthewbauer matthewbauer merged commit c2039e1 into NixOS:staging May 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat Awaiting requested review from vcunat

Assignees
No one assigned
Labels
8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 501+ 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@matthewbauer @Atemu