Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gotify-server: 2.0.15 -> 2.0.16 #87537

Merged
merged 1 commit into from May 10, 2020
Merged

gotify-server: 2.0.15 -> 2.0.16 #87537

merged 1 commit into from May 10, 2020

Conversation

doronbehar
Copy link
Contributor

@doronbehar doronbehar commented May 10, 2020 •
edited

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

doronbehar
doronbehar commented May 10, 2020
View reviewed changes
pkgs/servers/gotify/default.nix
@@ -38,6 +38,10 @@ buildGoModule rec {
cp -r ${ui}/libexec/gotify-ui/deps/gotify-ui/build ui/build && packr
'';

passthru = {
updateScript = ./update.sh;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected with:

nix-shell maintainers/scripts/update.nix --argstr package gotify-server

@ofborg ofborg bot requested a review from kalbasit May 10, 2020 20:23
@Ma27 Ma27 merged commit 532f434 into NixOS:master May 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalbasit kalbasit Awaiting requested review from kalbasit

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@doronbehar @Ma27