Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamspeak_client: update to 3.5.3 #87530

Merged
merged 1 commit into from May 19, 2020
Merged

teamspeak_client: update to 3.5.3 #87530

merged 1 commit into from May 19, 2020

Conversation

lukegb
Copy link
Contributor

@lukegb lukegb commented May 10, 2020 •
edited

Motivation for this change

TeamSpeak3 Client is out of date, and the new 3.5.3 includes some audio changes
that make it annoying (but not impossible) to use with old versions.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from nathanielbaxter May 10, 2020 19:25
@lukegb lukegb marked this pull request as draft May 10, 2020 22:11
@lukegb lukegb marked this pull request as ready for review May 11, 2020 00:53
@lukegb lukegb marked this pull request as draft May 11, 2020 18:56
@lukegb
teamspeak_client: 3.3.2 -> 3.5.3
029d3b3 
This now requires Qt5WebSockets, so that's been added as a dependency now.
@lukegb lukegb marked this pull request as ready for review May 16, 2020 23:56
@lukegb lukegb changed the title teamspeak_client: update to 3.5.2 teamspeak_client: update to 3.5.3 May 16, 2020
@edef1c edef1c added the 9.needs: port to stable A PR needs a backport to the stable release. label May 17, 2020
@Lassulus Lassulus merged commit aeeb341 into NixOS:master May 19, 2020
@lukegb lukegb deleted the update/teamspeak branch May 22, 2020 11:53
@david-sawatzke david-sawatzke mentioned this pull request Sep 11, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nathanielbaxter nathanielbaxter Awaiting requested review from nathanielbaxter

Assignees
No one assigned
Labels
9.needs: port to stable A PR needs a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@lukegb @edef1c @Lassulus