Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ocamlPackages.torch: init at 0.8 #87447

Merged
merged 1 commit into from May 26, 2020
Merged

ocamlPackages.torch: init at 0.8 #87447

merged 1 commit into from May 26, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented May 9, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • [NA] Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
Copy link
Member Author

bcdarwin commented May 9, 2020 •
edited

@GrahamcOfBorg eval

@bhipple
Copy link
Contributor

bhipple commented May 10, 2020

Result of nixpkgs-review pr 87447 1

7 packages marked as broken and skipped:
- linuxPackages_4_9.sysdig
- linuxPackages_hardkernel_4_14.nvidia_x11_legacy390
- linuxPackages_hardkernel_4_14.nvidiabl
- php73Extensions.zmq
- php74Extensions.pcs
- php74Extensions.zmq
- python37Packages.pyblock
1 package built:
- ocamlPackages.torch

@bhipple
Copy link
Contributor

bhipple commented May 26, 2020

Result of nixpkgs-review pr 87447 1

7 packages marked as broken and skipped:
- linuxPackages_hardkernel_4_14.nvidia_x11
- linuxPackages_hardkernel_4_14.nvidiabl
- php72Packages.phpmd
- php73Extensions.pcs
- php74Extensions.pcs
- python38Packages.notify
- python38Packages.pyblock
1 package built:
- ocamlPackages.torch

@bhipple bhipple merged commit 5e22232 into NixOS:master May 26, 2020
@bcdarwin bcdarwin deleted the ocaml-torch branch May 26, 2020 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

Assignees
No one assigned
Labels
6.topic: ocaml 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bcdarwin @bhipple