Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lite: init at 1.03 #87434

Merged
merged 1 commit into from May 13, 2020
Merged

lite: init at 1.03 #87434

merged 1 commit into from May 13, 2020

Conversation

prusnak
Copy link
Member

@prusnak prusnak commented May 9, 2020

Motivation for this change

Ultrafast editor written in Lua

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aaronjanse
Copy link
Member

I'd just like to confirm that I've built this PR on my laptop and, as far as I can tell, lite works as intended.

@mmahut
Copy link
Member

mmahut commented May 10, 2020

Problem on darwin:

/nix/store/0np9zfyh5rq4kymr2ldqj5w2n82v1n30-stdenv-darwin/setup: line 1315: gcc: command not found

@prusnak
Copy link
Member Author

prusnak commented May 10, 2020

darwin fixed in d90df25

@HugoReeves HugoReeves mentioned this pull request May 11, 2020
10 tasks
@prusnak
Copy link
Member Author

prusnak commented May 11, 2020

Added @filalex77 as a maintainer as per #87589 (comment)

@ofborg ofborg bot requested a review from Br1ght0ne May 11, 2020 23:59
@HugoReeves
Copy link
Member

HugoReeves commented May 12, 2020

Successfully built and executed the package on NixOS and MacOS Catalina.

Note that the 1.03 version does not have correct scaling on MacOS. This comment thread in the lite repo indicates that supporting MacOS is probably not within the scope of the rxi/lite repo. Maybe setting platforms = platforms.linux; would be advisable until MacOS support is confirmed.

@mmahut
Copy link
Member

mmahut commented May 12, 2020

@GrahamcOfBorg build lite

1 similar comment
@prusnak
Copy link
Member Author

prusnak commented May 13, 2020

@GrahamcOfBorg build lite

@mmahut mmahut merged commit d977371 into NixOS:master May 13, 2020
@prusnak prusnak deleted the lite branch May 13, 2020 16:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants