Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[20.03] vimUtils.vimrcFile: Backport fix packpath order #87543

Merged
merged 1 commit into from May 11, 2020

Conversation

maralorn
Copy link
Member

Motivation for this change

This is the backport of #78385. The comments of that PR said it should be backported. Sadly that never happened.

This broke e.g. haskell-vim syntax-highlighting when people upgraded from 19.09 to 20.03.
See: neovimhaskell/haskell-vim#111

My guess is that the problem was introduced into master around 8dccb59 from january. I could be wrong about that, but it definitely worked on 19.09.

So this was broken only for a few weeks. Sadly exactly when the branch-off happened.

@Mic92 @megheaiulian @jonringer

cc: @emptyflask

@bjornfor
Copy link
Contributor

@maralorn : backport commits should be made with "git cherry-pick -x ..."

@maralorn
Copy link
Member Author

Didn‘t know. Fixed.

@Mic92 Mic92 merged commit 5adf2a6 into NixOS:release-20.03 May 11, 2020
@maralorn maralorn deleted the fix-vim-plugin-order branch May 11, 2020 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants