Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vtk: 7.1.1 -> 8.2.0 #87544

Merged
merged 1 commit into from May 26, 2020
Merged

vtk: 7.1.1 -> 8.2.0 #87544

merged 1 commit into from May 26, 2020

Conversation

bcdarwin
Copy link
Member

@bcdarwin bcdarwin commented May 10, 2020 •
edited

  • also create vtk_7 as several packages don't build with 8.x:

    • itk5: vtkVersion.h header not found at compile time
    • ants: version in tree (2.2.0) is incompatible with 8.2
    • itk4: ants depends on both vtk and itk4, so use vtk_7
    • gdcm: vtk header issue
    • python3Packages.vtk: Python C API compilation error with Python 3.8

  • upgrade vtkWithQt4 -> vtkWithQt5

Motivation for this change

VTK 9 is out and some packages (e.g., Fury, not yet in Nixpkgs) now require 8 or higher.

Resolves #49531.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • [NA] Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
4 package marked as broken and skipped:
linuxPackages_hardkernel_4_14.r8125 linuxPackages_hardkernel_4_14.r8168 qes smimesign

13 package built:
cq-editor freecad mirtk opencascade pcl python27Packages.pythonocc-core python37Packages.cadquery python37Packages.pythonocc-core python38Packages.pythonocc-core smesh vtk vtk7 vtkWithQt5
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bcdarwin
Copy link
Member Author

bcdarwin commented May 10, 2020 •
edited

@GrahamcOfBorg eval

@ofborg ofborg bot requested a review from knedlsepp May 10, 2020 21:20
FRidh
FRidh requested changes May 11, 2020
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@bcdarwin bcdarwin requested a review from FRidh May 11, 2020 21:45
@bcdarwin
vtk: 7.1.1 -> 8.2.0
5e716bf 
- also create vtk_7 as several packages don't build with 8.x:
  - itk5: vtkVersion.h header not found at compile time
  - ants: version in tree (2.2.0) is incompatible with 8.2
  - itk4: ants depends on both vtk and itk4, so use vtk_7
  - gdcm: vtk header issue
  - python3Packages.vtk: Python C API compilation error with Python 3.8

- upgrade vtkWithQt4 -> vtkWithQt5
@bhipple
Copy link
Contributor

bhipple commented May 26, 2020

Result of nixpkgs-review pr 87544 1

13 packages built:
- cq-editor
- freecad
- mirtk
- opencascade
- pcl
- python27Packages.pythonocc-core
- python37Packages.cadquery
- python37Packages.pythonocc-core
- python38Packages.pythonocc-core
- smesh
- vtk
- vtkWithQt5
- vtk_7

@bhipple bhipple merged commit d3082a3 into NixOS:master May 26, 2020
@bcdarwin bcdarwin deleted the vtk-8 branch May 26, 2020 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple approved these changes

@jonringer jonringer Awaiting requested review from jonringer

@knedlsepp knedlsepp Awaiting requested review from knedlsepp

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Please update to vtk 8.2.0
3 participants
@bcdarwin @bhipple @FRidh