Fix #8045: [AI/GS] Estimate costs for failed commands #8046
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure of this fix in a larger scale. I tested against my AI and it now gets the estimated costs correctly for
AIVehicle.CloneVehicle
even when it is returned as failed.Maybe the alternative would be to change
CmdCloneVehicle
to return true to estimate costs, I'm unsure.OpenTTD/src/vehicle_cmd.cpp
Lines 978 to 986 in 55e81d3