Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-direnv: init at 1.0.0 #87475

Merged
merged 3 commits into from May 11, 2020
Merged

nix-direnv: init at 1.0.0 #87475

merged 3 commits into from May 11, 2020

Conversation

DamienCassou
Copy link
Contributor

Motivation for this change

Add nix-direnv, a fast, persistent use_nix implementation for direnv.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @Mic92

@DamienCassou
Copy link
Contributor Author

Result of nixpkgs-review pr 87475 1

1 package built:
- nix-direnv

@DamienCassou DamienCassou mentioned this pull request May 10, 2020
Closed
@Mic92 Mic92 changed the title nix-direnv: init at 2020.04.20 nix-direnv: init at 1.0.0 May 10, 2020
@Mic92 Mic92 merged commit b690b78 into NixOS:master May 11, 2020
@ofborg ofborg bot requested a review from Mic92 May 11, 2020 07:46
@DamienCassou DamienCassou deleted the damien/nix-direnv branch May 11, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjornfor bjornfor bjornfor requested changes

@Mic92 Mic92 Awaiting requested review from Mic92

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@DamienCassou @bjornfor @Mic92