Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/monit: Allow splitting the config in multiple files #87553

Merged
merged 1 commit into from Aug 22, 2020

Conversation

JoeDupuis
Copy link
Contributor

Motivation for this change

This allow splitting the config into multiple files.
It also allow building the list of config files from different expressions, keeping things organized.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Sep 18, 2020

@JoeDupuis I don't understand the point of this. You could already build your configuration over multiple expressions and the NixOS module system would join them into the single /etc/monitrc file. With this, you have go rooting around in a bunch of different nix store paths to see what is going on.

I'm in favor of reverting this.

@JoeDupuis
Copy link
Contributor Author

Oopsie. Didn't thought the fields would append. Thought they would override.
My bad.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants