Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

linux: explicitly enable AIO #87554

Merged
merged 1 commit into from Jun 17, 2020
Merged

linux: explicitly enable AIO #87554

merged 1 commit into from Jun 17, 2020

Conversation

emilazy
Copy link
Member

@emilazy emilazy commented May 10, 2020

Motivation for this change

This is disabled by default in the linux-hardened patchset, but is required by e.g. LVM.

Fixes #87260.

Unfortunately I couldn't easily figure out a good way to test LVM in a NixOS test; suggestions welcome.

@GrahamcOfBorg test hardened

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@emilazy
linux: explicitly enable AIO
4688ec0 
This is disabled by default in the linux-hardened patchset, but is
required by e.g. LVM.

Fixes NixOS#87260.
@emilazy
Copy link
Member Author

emilazy commented May 11, 2020 •
edited

@GrahamcOfBorg test hardened

@cyplo
Copy link
Contributor

cyplo commented May 12, 2020

I did test this change on a computer that had trouble booting before and this fixes that - thanks :)

@Mic92 Mic92 merged commit df54fe6 into NixOS:master Jun 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 501+ 10.rebuild-linux: 1001-2500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

cannot boot linux_latest_hardened on lvm-on-luks anymore
3 participants
@emilazy @cyplo @Mic92