Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Crash on loading savegame from #4524 (station related) #8132

Closed
James103 opened this issue May 10, 2020 · 0 comments
Closed

Crash on loading savegame from #4524 (station related) #8132

James103 opened this issue May 10, 2020 · 0 comments

Comments

@James103
Copy link
Contributor

Version of OpenTTD

20200509-master

Expected result

The game loads and simulates normally.

Actual result

The game asserts here:

OpenTTD/src/bitmap_type.h

Lines 80 to 84 in a95fbd5

inline void SetTile(TileIndex tile)
{
assert(this->Contains(tile));
this->data[Index(tile)] = true;
}

Crash log: crash.zip

Stackdump on loading:

 	KERNELBASE.dll!00007ff8b86d9709()	Unknown
>	openttd.exe!HandleSavegameLoadCrash(int signum) Line 430	C++
 	openttd.exe!raise(int signum) Line 516	C++
 	openttd.exe!abort() Line 71	C++
 	openttd.exe!error(const char * s, ...) Line 127	C++
 	openttd.exe!BitmapTileArea::SetTile(unsigned int tile) Line 82	C++
 	openttd.exe!Station::RecomputeCatchment() Line 448	C++
 	openttd.exe!Station::RecomputeCatchmentForAll() Line 478	C++
 	openttd.exe!AfterLoadGame() Line 3142	C++
 	openttd.exe!DoLoad(LoadFilter * reader, bool load_check) Line 2693	C++
 	openttd.exe!SaveOrLoad(const char * filename, SaveLoadOperation fop, DetailedFileType dft, Subdirectory sb, bool threaded) Line 2802	C++
 	openttd.exe!SafeLoad(const char * filename, SaveLoadOperation fop, DetailedFileType dft, GameMode newgm, Subdirectory subdir, LoadFilter * lf) Line 1009	C++
 	openttd.exe!SwitchToMode(SwitchMode new_mode) Line 1093	C++
 	openttd.exe!GameLoop() Line 1466	C++
 	openttd.exe!VideoDriver_Win32::MainLoop() Line 1264	C++
 	openttd.exe!openttd_main(int argc, char * * argv) Line 860	C++
 	openttd.exe!WinMain(HINSTANCE__ * hInstance, HINSTANCE__ * hPrevInstance, char * lpCmdLine, int nCmdShow) Line 442	C++
 	[External Code]

Steps to reproduce

Load the attached savegame:
#4524 - MC Transport-fixed2.zip

Release notes

The savegame loads fine in release versions (1.10.1), but crashes randomly if you wait long enough. Example crashlog: crash2.zip
glx22 added a commit to glx22/OpenTTD that referenced this issue May 10, 2020
@glx22
Fix OpenTTD#8132:
b450f70
glx22 added a commit to glx22/OpenTTD that referenced this issue May 10, 2020
@glx22
Fix OpenTTD#8132: Corrupted savegame crashing openttd on load
bb0ec26
glx22 added a commit to glx22/OpenTTD that referenced this issue May 10, 2020
@glx22
Fix OpenTTD#8132: Corrupted savegame crashing OpenTTD on load
414b661
LordAro pushed a commit to LordAro/OpenTTD that referenced this issue May 10, 2020
@glx22 @LordAro
Fix OpenTTD#8132: Corrupted savegame crashing OpenTTD on load
eaeedc5
LordAro pushed a commit that referenced this issue Jun 1, 2020
@glx22 @LordAro
Fix #8132: Corrupted savegame crashing OpenTTD on load
a089c87
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@James103