nix-env: validate json outputsToInstall #3584
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cole-h
reviewed
May 10, 2020
LnL7
force-pushed
the
query-outputs-to-install
branch
from
f1c2d5d
to
8ac5d67
Compare
|
Alternatively I could add this to |
|
It seems misleading that I agree it would be better to add it to |
LnL7
force-pushed
the
query-outputs-to-install
branch
from
8ac5d67
to
3a91ec9
Compare
This means meta.outputsToInstall is now always available, even when not defined by the derivation (ie. all outputs). Also enforces it's value is valid, useful for tooing that evaluates nix expressions like ofborg. Similar logic is used by the channel update script https://github.com/NixOS/nixos-channel-scripts/blob/7a681103b2b3ce150f7f96394f19aa0ad4797ca1/generate-programs-index.cc#L1
LnL7
force-pushed
the
query-outputs-to-install
branch
from
3a91ec9
to
85e8add
Compare
|
I wasn't sure what the behaviour of |
LnL7
changed the title
|
I marked this as stale due to inactivity. → More info |
|
I closed this issue due to inactivity. → More info |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This isn't particularly useful since the json output already includes
metadata. However the evaluation behaves differently, in this case
meta.outputsToInstallis also validated. The same is done by thechannel index generation but it's currently not exposed in a way other
tools like ofborg could use it.
https://github.com/NixOS/nixos-channel-scripts/blob/7a681103b2b3ce150f7f96394f19aa0ad4797ca1/generate-programs-index.cc#L110
If this flag is added to the ofborg evaluation checks it should catch problems like NixOS/nixpkgs#87138 in the future.
/cc @grahamc @cole-h