Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python.pkgs.scikitlearn: 0.21.3 -> 0.22.2.post1 #87527

Merged
merged 2 commits into from May 12, 2020
Merged

python.pkgs.scikitlearn: 0.21.3 -> 0.22.2.post1 #87527

merged 2 commits into from May 12, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented May 10, 2020 •
edited

Motivation for this change

Surprisingly to me, scikitlearn hasn't been updated since November. Since I couldn't find a reason for that, here's the update.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@timokau
Copy link
Member Author

timokau commented May 10, 2020

nix-review:

15 packages failed to build:
python37Packages.imbalanced-learn python37Packages.optuna python37Packages.persim python37Packages.pygbm python37Packages.qasm2image python37Packages.qiskit python37Packages.qiskit-aqua python37Packages.ripser python37Packages.scikit-tda python38Packages.imbalanced-learn python38Packages.persim python38Packages.pygbm python38Packages.qiskit-aqua python38Packages.ripser python38Packages.scikit-tda

53 packages built:
python37Packages.batchgenerators python37Packages.bayesian-optimization python37Packages.dask-glm python37Packages.dask-ml python37Packages.dask-xgboost python37Packages.dftfit python37Packages.graspy python37Packages.hdbscan python37Packages.hmmlearn python37Packages.ignite python37Packages.kmapper python37Packages.librosa python37Packages.lightgbm python37Packages.mlrose python37Packages.nilearn python37Packages.osmnx python37Packages.qiskit-ignis python37Packages.scikit-bio python37Packages.scikit-optimize python37Packages.scikitlearn python37Packages.sklearn-deap python37Packages.textacy python37Packages.umap-learn python37Packages.vowpalwabbit python37Packages.word2vec python37Packages.xgboost python38Packages.batchgenerators python38Packages.bayesian-optimization python38Packages.dask-glm python38Packages.dask-ml python38Packages.dask-xgboost python38Packages.dftfit python38Packages.graspy python38Packages.hdbscan python38Packages.hmmlearn python38Packages.ignite python38Packages.kmapper python38Packages.librosa python38Packages.lightgbm python38Packages.mlrose python38Packages.nilearn python38Packages.osmnx python38Packages.qiskit-ignis python38Packages.scikit-bio python38Packages.scikit-optimize python38Packages.scikitlearn python38Packages.sklearn-deap python38Packages.textacy python38Packages.umap-learn python38Packages.vowpalwabbit python38Packages.word2vec python38Packages.xgboost tebreak

@timokau
Copy link
Member Author

timokau commented May 10, 2020

All of the failures are broken on master already.

bhipple
bhipple approved these changes May 11, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actual bump looks good. 👍

pkgs/development/python-modules/scikitlearn/default.nix
minor = versions.minor version;
dashVer = replaceChars ["."] ["-"] version;
in
"https://scikit-learn.org/stable/whats_new/v${major}.${minor}.html#version-${dashVer}";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great. I'm going to update the nixpkgs-update bot to drop a link to meta.description in the PR description if it exists, btw:

ryantm/nixpkgs-update#200

I spent a lot of time looking for release notes when reviewing PRs, so it'll be good to have it a little more streamlined!

@jonringer
Copy link
Contributor

@GrahamcOfBorg build python3Packages.scikitlearn
@GrahamcOfBorg build python38Packages.scikitlearn

@timokau timokau merged commit ebf030b into NixOS:master May 12, 2020
@timokau timokau deleted the scikitlearn-0.22.2 branch May 12, 2020 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

@bhipple bhipple bhipple approved these changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@timokau @jonringer @prusnak @bhipple