Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lapin test binaries #500

Merged
merged 2 commits into from May 24, 2020
Merged

lapin test binaries #500

merged 2 commits into from May 24, 2020

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented May 24, 2020

Last bit of the transition.

LnL7 added 2 commits May 24, 2020 19:43
@LnL7
convert log message generator to easylapin
6014e08 
Just a utility, not used or needed by any of the services.
@LnL7
convert build faker to easylapin
b464c29 
Another utility used just for testing.
cole-h
cole-h approved these changes May 24, 2020
View reviewed changes
Copy link
Member

@cole-h cole-h left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple questions (well one question, occurring twice), but overall LGTM.

ofborg/src/bin/build-faker.rs
info!("Closed the channel");
session.close(200, "Good Bye");
info!("Closed the session... EOF");
Ok(())
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't need to drop(conn); here?

ofborg/src/bin/log-message-generator.rs Show resolved Hide resolved
@LnL7 LnL7 merged commit cdf8cbb into NixOS:released May 24, 2020
@LnL7 LnL7 deleted the lapin-test-binaries branch May 24, 2020 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cole-h cole-h cole-h approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@LnL7 @cole-h