Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vscode-extensions/update-8 #88843

Merged
merged 2 commits into from
Aug 9, 2020
Merged

vscode-extensions/update-8 #88843

merged 2 commits into from
Aug 9, 2020
+14 −11

Conversation

eadwu
Copy link
Member

@eadwu eadwu commented May 25, 2020

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@eadwu eadwu requested a review from jonringer as a code owner May 25, 2020 01:11
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 25, 2020
jonringer
jonringer reviewed May 28, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

having issues with the python extension:

trying https://ms-python.gallery.vsassets.io/_apis/public/gallery/publisher/ms-python/extension/python/2020.5.80290/assetbyname/Microsoft.VisualStudio.Services.VSIXPackage
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
 11 44.1M   11 5156k    0     0   136k      0  0:05:31  0:00:37  0:04:54  569k
curl: (18) transfer closed with 40970331 bytes remaining to read
** Resuming transfer from byte position 5280295
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
  0 44.1M    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
curl: (33) HTTP server doesn't seem to support byte ranges. Cannot resume.

@eadwu eadwu force-pushed the vscode-extensions/update-8 branch 2 times, most recently from 62d3d5e to 616a0f1 Compare May 28, 2020 14:51
@eadwu
Copy link
Member Author

eadwu commented May 28, 2020

Depends on #89112 now.

I think the src might be the server's problem (sounds really familiar but not sure), tried fetching the vsix from Github?

@jonringer
Copy link
Contributor

jonringer commented May 28, 2020 •
edited
Loading

I think the src might be the server's problem (sounds really familiar but not sure), tried fetching the vsix from Github?

probably, not sure how to fix :(

@eadwu
Copy link
Member Author

eadwu commented May 29, 2020

Does the Github VSIX have any problems in regards to fetching the zip? The extension itself seems to working fine from what I've used.

@eadwu
Copy link
Member Author

eadwu commented May 30, 2020

From a raw comparison using diff and find, it looks like python-language-server has all the files, just in a different directory format, I'll see if I can use that for the extension.

@eadwu eadwu force-pushed the vscode-extensions/update-8 branch from 0f51165 to b943d6c Compare July 20, 2020 02:17
@jonringer
Copy link
Contributor

thanks for continuing to work on this, but do you mind squashing the intermediate bumps? Should only be the 2 extensions

@eadwu
Copy link
Member Author

eadwu commented Aug 6, 2020

Squashed.

@eadwu eadwu force-pushed the vscode-extensions/update-8 branch from e9c7f09 to d4f8809 Compare August 6, 2020 18:55
@jonringer jonringer merged commit da65bc1 into NixOS:master Aug 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jonringer jonringer

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@eadwu @jonringer